Support shortening of revision with digest #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
digest-revision-fmt
branch
4 times, most recently
from
4859b29
to
fdd45f6
Compare
This was referenced Feb 15, 2023
hiddeco
force-pushed
the
digest-revision-fmt
branch
2 times, most recently
from
ed5e0e7
to
d8bc9f0
Compare
hiddeco
force-pushed
the
digest-revision-fmt
branch
from
d8bc9f0
to
5808956
Compare
|
Should messages like this also be shortened? |
|
Not required as it isn't part of column based output where width is a luxury. Also think that a full reference is better there in general, as it is more precise. |
The `\b` in the regular expression ensures we only match with a hexadecimal notation as awhole, while still allowing to match with e.g. `sha1:...` which would not have been possible by using `\W` as this includes `_`. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
force-pushed
the
digest-revision-fmt
branch
from
5808956
to
bb6a7b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.