fix: Avoid printing an extra newline when exporting resources #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Mar 23, 2023
exporting Signed-off-by: Yiannis <yiannistri@users.noreply.github.com>
yiannistri
force-pushed
the
3593-fix-double-newline
branch
from
7573895
to
b55f49b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3593
Following Hidde's hint, the change in this PR should prevent extra newlines from being printed. This affects both the
flux export ..command and the--exportflag used in other Flux commands.Also tested with
and it no longer produces a newline between resources in the same file.