Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResourceQuota for critical pods #3879

Merged
merged 1 commit into from
May 12, 2023
Merged

Add ResourceQuota for critical pods #3879

merged 1 commit into from
May 12, 2023

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented May 12, 2023

Added ResourceQuota for critical pods set to max 1K pods to allow horizontal scaling and sharding.

Fixes insufficient quota error on GKE, reported here.

Tested on GKE 1.26

$ flux check
► checking prerequisites
✔ Kubernetes 1.26.2-gke.1000 >=1.20.6-0
► checking controllers
✔ helm-controller: deployment ready
► ghcr.io/fluxcd/helm-controller:v0.32.2
✔ kustomize-controller: deployment ready
► ghcr.io/fluxcd/kustomize-controller:v1.0.0-rc.2
✔ notification-controller: deployment ready
► ghcr.io/fluxcd/notification-controller:v1.0.0-rc.2
✔ source-controller: deployment ready
► ghcr.io/fluxcd/source-controller:v1.0.0-rc.2
► checking crds
✔ alerts.notification.toolkit.fluxcd.io/v1beta2
✔ buckets.source.toolkit.fluxcd.io/v1beta2
✔ gitrepositories.source.toolkit.fluxcd.io/v1
✔ helmcharts.source.toolkit.fluxcd.io/v1beta2
✔ helmreleases.helm.toolkit.fluxcd.io/v2beta1
✔ helmrepositories.source.toolkit.fluxcd.io/v1beta2
✔ kustomizations.kustomize.toolkit.fluxcd.io/v1
✔ ocirepositories.source.toolkit.fluxcd.io/v1beta2
✔ providers.notification.toolkit.fluxcd.io/v1beta2
✔ receivers.notification.toolkit.fluxcd.io/v1
✔ all checks passed

PS. We need to find a better place for the manifest location, but since this requires changes to the manifest generation logic and packaging, I'll leave it for another time.

@stefanprodan stefanprodan added bug Something isn't working area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests labels May 12, 2023
@stefanprodan stefanprodan requested a review from a team May 12, 2023 06:23
@stefanprodan stefanprodan mentioned this pull request May 12, 2023
9 tasks
Fixes insufficient quota error on GKE

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests area/install Install and uninstall related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants