Add target path to the bootstrap cmd #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Jun 12, 2020
cmd/tk/bootstrap_github.go
Outdated
| @@ -417,7 +423,7 @@ func generateGitHubKustomization(url, name, namespace, tmpDir string, interval t | |||
| Interval: metav1.Duration{ | |||
| Duration: 10 * time.Minute, | |||
| }, | |||
| Path: "./", | |||
| Path: "./" + targetPath, | |||
There was a problem hiding this comment.
Doesn't work, as join removes ./ and that breaks the CRD validation.
There was a problem hiding this comment.
I added a trim to guard against double ./.
stefanprodan
force-pushed
the
bootstrap-path
branch
from
30de18e
to
4992e11
Compare
hiddeco
approved these changes
Jun 12, 2020
ybelleguic
pushed a commit
to ybelleguic/flux2
that referenced
this pull request
Jan 9, 2023
deploy: reusable config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional flag to the bootstrap command that allows specifying a repository path where the manifests will be placed. When a path is specified, the cluster sync is configured for the target path. Using a path per cluster, a repository can be used to define the desired state of a fleet of clusters.