Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix break lines in create helmrelease and source #3924

Merged
merged 1 commit into from
May 26, 2023

Conversation

hgranillo
Copy link
Contributor

@hgranillo hgranillo commented May 26, 2023

Hello flux maintainers!

This PR fixes a few missing break lines in the create helmrelease and create source help documentation that could lead to some unintended executions if blindly copy-pasted

For example, I've added --export to the create source helm OCI example included in the flux create source helm --help command:

Discovered this while I was pasting examples in my terminal with the --export flag to check if I was using the newest API versions for my flux objects

❯   flux create source helm podinfo \
    --url=oci://ghcr.io/stefanprodan/charts/podinfo
    --username=username \
    --password=password --export
✚ generating HelmRepository source
► applying HelmRepository source
✔ source updated
◎ waiting for HelmRepository source reconciliation
^C

Signed-off-by: Horacio Granillo <horacio.granillo@smarttra.de>
@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label May 26, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hgranillo

@stefanprodan stefanprodan merged commit a5b1b04 into fluxcd:main May 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants