image name has ":"

[StillP]

If the name of image has ":", that will not get correct version. Now I try fix it.

[makkes]

Colons are not allowed in OCI image references so I'm not sure what this PR is solving really.

[hiddeco]

The problem here seems to be that it relies on the container image from the Deployment and/or Pod spec, which can contain e.g. fictional.registry.example:10443/imagename:tag. See: https://kubernetes.io/docs/concepts/containers/images/#image-names.

But at the same time, this is already taken into account by the usage of len. This is not true for the tag extraction.

[makkes]

The problem here seems to be that it relies on the container image from the Deployment and/or Pod spec, which can contain e.g. fictional.registry.example:10443/imagename:tag.

Oh, I see. That makes sense.

[stefanprodan]

We could use the image parse function instead https://github.com/fluxcd/pkg/blob/5b608cb95e2129ad9cf19ed6e26f87003518a70e/oci/client/tag.go#L29C10-L29C10

[makkes]

@StillP please make sure to follow our contribution guide by

• agreeing to the DCO
• using a proper commit title and message
• bonus: providing a regression test

[stefanprodan]

Superseded by #4180