Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address various issues throughout code base #4329

Merged
merged 14 commits into from
Oct 17, 2023
Merged

Address various issues throughout code base #4329

merged 14 commits into from
Oct 17, 2023

Commits on Oct 17, 2023

  1. misc: address strings.Title deprecation 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    16d352b View commit details
    Browse the repository at this point in the history

  2. misc: handle undhandled error 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    b67a463 View commit details
    Browse the repository at this point in the history

  3. misc: address unnecessary use of fmt.Sprintf 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3c49586 View commit details
    Browse the repository at this point in the history

  4. misc: use raw string for regex to avoid double esc 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    a2a3b4f View commit details
    Browse the repository at this point in the history

  5. misc: address double import 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    43c2359 View commit details
    Browse the repository at this point in the history

  6. misc: simplify row append 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3278a07 View commit details
    Browse the repository at this point in the history

  7. misc: address kustomize/api/filesys deprecation 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    5b22207 View commit details
    Browse the repository at this point in the history

  8. misc: unconditional strings.TrimPrefix 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ce3e264 View commit details
    Browse the repository at this point in the history

  9. misc: use errors.As instead of type checking 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    22134b1 View commit details
    Browse the repository at this point in the history

  10. misc: address wait.PollImmediate deprecation 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3fdb292 View commit details
    Browse the repository at this point in the history

  11. misc: remove unused bits of code 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    f5d3283 View commit details
    Browse the repository at this point in the history

  12. misc: sinceSeconds -> sinceDuration 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    e3f6f0f View commit details
    Browse the repository at this point in the history

  13. misc: fix hypothetical implicit memory aliasing 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ba1180a View commit details
    Browse the repository at this point in the history

  14. misc: clean up immediately and avoid delayed defer 

    Signed-off-by: Hidde Beydals <hidde@hhh.computer>
    @hiddeco
    hiddeco committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    f137263 View commit details
    Browse the repository at this point in the history