feat(secret): add create notation secret handler #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
reviewed
Apr 22, 2024
souleb
reviewed
Apr 22, 2024
|
can you please squash your commits? |
souleb
reviewed
Apr 23, 2024
JasonTheDeveloper
force-pushed
the
feat/4692
branch
from
60272c3
to
4fd45ec
Compare
|
@JasonTheDeveloper can you please squash and rebase with main please. |
JasonTheDeveloper
force-pushed
the
feat/4692
branch
4 times, most recently
from
997eb0d
to
9a6f519
Compare
Signed-off-by: Jason <jagoodse@microsoft.com>
JasonTheDeveloper
force-pushed
the
feat/4692
branch
from
46faf61
to
c49ba9d
Compare
|
@stefanprodan @souleb all commits have been squashed. |
souleb
approved these changes
Apr 23, 2024
stefanprodan
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in relation to #4692.
The purpose of this PR is to aid in the creation of notation configuration secret used to validate artifacts signed by notation. The
create secret notationwill only add root CA certificates ending in.crtand.pemand validtrust-policy.json. You can pass in multiple root CA certificates as well as a folder containing multiple certs.