Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor get source commands #761

Merged
merged 1 commit into from Jan 26, 2021
Merged

Refactor get source commands #761

merged 1 commit into from Jan 26, 2021

Conversation

somtochiama
Copy link
Member

@somtochiama somtochiama commented Jan 22, 2021

Ref: #291

Signed-off-by: Somtochi Onyekwere somtochionyekwere@gmail.com

cmd/flux/source.go Outdated Show resolved Hide resolved
@stefanprodan stefanprodan changed the title Use adapter pattern for get source bucket Refactor get source commands Jan 25, 2021
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @somtochiama, can you please: rebase, squash the commits, signoff and rename the commit to "Refactor get source commands"

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
@stefanprodan stefanprodan merged commit 13aa523 into fluxcd:main Jan 26, 2021
@somtochiama somtochiama deleted the cli-refactoring branch March 25, 2021 10:47
ybelleguic pushed a commit to ybelleguic/flux2 that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants