Add permissions for controller leader election. #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v0.8.0 version of the controller-runtime uses both config maps and leases to perform leader election. These permissions seem to be in the individual controller repos, but not here. For example https://github.com/fluxcd/kustomize-controller/blob/2d38de8779b68bde3366489a0b7657488c747fdb/config/rbac/leader_election_role.yaml#L33-L44 Signed-off-by: Brian Atkinson <brian@atkinson.mn>
stefanprodan
added
the
area/install
ybelleguic
pushed a commit
to ybelleguic/flux2
that referenced
this pull request
Jan 9, 2023
Update dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v0.8.0 version of the controller-runtime uses both config maps and
leases to perform leader election. These permissions seem to be in the
individual controller repos, but not here. For example
https://github.com/fluxcd/kustomize-controller/blob/2d38de8779b68bde3366489a0b7657488c747fdb/config/rbac/leader_election_role.yaml#L33-L44