[Stash] Implement user service operations #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
force-pushed
the
go-stash-user-service
branch
2 times, most recently
from
9f0d422
to
75b64aa
Compare
souleb
force-pushed
the
go-stash-user-service
branch
4 times, most recently
from
87a1a02
to
9485b71
Compare
stefanprodan
changed the title
yiannistri
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
Just a couple of typos but overall looks good, thanks @souleb 👌
UserService permits retrieving indivudual users and listing them. Signed-off-by: Soule BA <soule@weave.works>
souleb
force-pushed
the
go-stash-user-service
branch
from
9485b71
to
e860d6e
Compare
souleb
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserService permits retrieving indivudual users and listing them.
Signed-off-by: Soule BA soule@weave.works
Description
This add the client service UserService to communicate with the following rest endpoints:
/rest/api/1.0/users
/rest/api/1.0/users/{userSlug}
It is used here, in the current implementation to list and get users
A small change to http client as well to hide the dependency to retryablehttp.
Test results
https://github.com/souleb/go-git-providers/actions/runs/1220830834
https://github.com/souleb/go-git-providers/runs/3564757557?check_suite_focus=true