-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stash] This add the stash client service GroupService #103
Conversation
9485b24
to
ce872a2
Compare
0a9f74c
to
37774b4
Compare
I think the code is good in the MRs #103 / #104, the only thing that I noticed was around the The |
48bc44c
to
0f2a926
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this!
…owing rest endpoints: /rest/api/1.0/admin/groups /rest/api/1.0/admin/groups/more-members Signed-off-by: Soule BA <soule@weave.works>
0f2a926
to
7d81a58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌 Thanks for adding this @souleb ✨
#102
Signed-off-by: Soule BA soule@weave.works
Description
This add the client service GroupService to communicate with the following rest endpoints:
Test results
https://github.com/souleb/go-git-providers/runs/3587059251?check_suite_focus=true