Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stash] This add the stash client service GroupService #103

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

souleb
Copy link
Member

@souleb souleb commented Sep 13, 2021

#102

Signed-off-by: Soule BA soule@weave.works

Description

This add the client service GroupService to communicate with the following rest endpoints:

  • /rest/api/1.0/admin/groups
  • /rest/api/1.0/admin/groups/more-members

Test results

https://github.com/souleb/go-git-providers/runs/3587059251?check_suite_focus=true

@souleb souleb mentioned this pull request Sep 13, 2021
13 tasks
@souleb souleb changed the title [STASH] This add the stash client service GroupService [stash] This add the stash client service GroupService Sep 13, 2021
@souleb souleb changed the title [stash] This add the stash client service GroupService [Stash] This add the stash client service GroupService Sep 13, 2021
@souleb souleb force-pushed the go-stash-groups-service branch 3 times, most recently from 0a9f74c to 37774b4 Compare September 14, 2021 15:55
@Nalum
Copy link
Member

Nalum commented Sep 15, 2021

I think the code is good in the MRs #103 / #104, the only thing that I noticed was around the client.go and client_test.go files. Both #103 and #104 seem to introduce them from different locations and also include the same changes introducing the service type, which will cause a conflict. Don't think it's a big issue really but thought I'd mention it.

The resources.go, users.go and users_test.go might also be a conflict issue. Looks like they were moved in #103 and created in #104.

go_stash/client.go Outdated Show resolved Hide resolved
go_stash/client.go Outdated Show resolved Hide resolved
go_stash/groups_test.go Outdated Show resolved Hide resolved
go_stash/groups_test.go Outdated Show resolved Hide resolved
go_stash/groups_test.go Outdated Show resolved Hide resolved
go_stash/groups.go Outdated Show resolved Hide resolved
go_stash/groups.go Outdated Show resolved Hide resolved
@souleb souleb force-pushed the go-stash-groups-service branch 2 times, most recently from 48bc44c to 0f2a926 Compare September 19, 2021 13:34
Copy link
Contributor

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this!

…owing rest endpoints:

    /rest/api/1.0/admin/groups
    /rest/api/1.0/admin/groups/more-members

Signed-off-by: Soule BA <soule@weave.works>
Copy link
Collaborator

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 Thanks for adding this @souleb

@yiannistri yiannistri merged commit 8b37850 into fluxcd:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants