Change default branch in github integration tests to main #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 58.89% 59.13% +0.23%
==========================================
Files 38 38
Lines 1708 1708
==========================================
+ Hits 1006 1010 +4
+ Misses 574 569 -5
- Partials 128 129 +1
Continue to review full report at Codecov.
|
|
The library should be able to create a branch even if it doesn't match the default. In GOTK we have users that want to create repos with a |
|
Yes, this is currently possible by setting the optional default branch for the repo in the gitprovider.RepositoryInfo struct, when calling OrgRepositories().Create(). It is not covered by the integration tests though, added ticket #62 for this. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default branch in newly created github repos has been renamed from
mastertomain. This change corrects the validation of repos in github integration tests.When the branch name changes in other providers the value in gitprovider/types_repository.go can be updated too as per the related comments.