POC implementation spec draft #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
poc/spec
branch
2 times, most recently
from
4df5e43
to
3f84972
Compare
Merged
hiddeco
force-pushed
the
poc/spec
branch
7 times, most recently
from
9db6856
to
1a5875c
Compare
* fixed Helm logging * fixed existing release error check
hiddeco
force-pushed
the
poc/spec
branch
6 times, most recently
from
aa8c6c1
to
23b6631
Compare
* newline fixes * source-controller v0.0.2 -> v0.0.3 * pkg v0.0.2 -> v0.0.3 * const for HelmRelease kind * wording change in README * lockfile error message fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a POC implementation of the spec draft to be able to further draft the spec based on technical findings. It provides full coverage of common Helm actions while also allowing extensive configuration options per action, but is currently limited in the ways actions are triggered (i.e. rolling back on a test failure is not possible yet, but it does perform a rollback on upgrade failures).