Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HelmChartTemplateSpec Doc missing valuesFiles info #266

Merged
merged 1 commit into from
May 24, 2021

Conversation

filintod
Copy link
Contributor

The spec docs differs from the api docs, missing the information about ValuesFiles. This also is not shown in https://fluxcd.io/docs/components/helm/helmreleases/#specification that I guess comes from this file and why I realized it was no there. I'm not sure if there is an automation for this file or not but did not find it, I saw one for the api doc one.

Signed-off-by: Filinto Duran duranto@gmail.com

Signed-off-by: Filinto Duran <duranto@gmail.com>
@filintod filintod force-pushed the fix-helm-release-spec-doc-values branch from 6d06681 to 261fc6b Compare May 22, 2021 13:37
@filintod filintod changed the title Fix HelmChartTemplateSpec missing valuesFiles info Fix HelmChartTemplateSpec Doc missing valuesFiles info May 22, 2021
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @filintod

@stefanprodan stefanprodan merged commit 577925c into fluxcd:main May 24, 2021
@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants