Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indentation for PostRenderers example #314

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fix indentation for PostRenderers example #314

merged 1 commit into from
Aug 30, 2021

Conversation

nuriel77
Copy link
Contributor

@nuriel77 nuriel77 commented Aug 23, 2021 •
edited
Loading

Having used the indentation from the example, images and patchesJson6902 are under kustomize. That resulted in the error:

validation failed: error: error validating "10f75846-394d-40a5-9fa1-73cd189b8703.yaml": error validating data: ValidationError(HelmRelease.spec.postRenderers[0]): unknown field "images" in io.fluxcd.toolkit.helm.v2beta1.HelmRelease.spec.postRenderers; if you choose to ignore these errors, turn validation off with --validate=false

Having shifted images as a field of kustomize seems to have worked.

@nuriel77
Fix indentation for PostRenderers example
99dcd96 
Signed-off-by: Nuriel Shem-Tov <nurielst@hotmail.com>
hiddeco
hiddeco approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks @nuriel77 🍰

@hiddeco hiddeco merged commit 4c528cb into fluxcd:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nuriel77 @hiddeco