Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Refactor Fuzz tests based on Go native fuzzing #517

Merged
merged 2 commits into from Aug 24, 2022

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Aug 13, 2022

Moving into Go Native, the adhoc changes and on-demand build is no
longer necessary.

Previously calls to r.EventRecorder.AnnotatedEventf resulted in panic.
The new dummy recorder resolves the problem without impacting
resource consumption.

A new make target fuzz-native was introduced, to loop through all
fuzz tests for the duration of time specified via the environment
variable FUZZ_TIME.

Part of fluxcd/flux2#2417.

@pjbgf pjbgf changed the title fuzz: Refactor Fuzzers based on Go native fuzzing fuzz: Refactor Fuzz tests based on Go native fuzzing Aug 17, 2022
@pjbgf pjbgf marked this pull request as ready for review August 17, 2022 17:02
@pjbgf
Copy link
Member Author

pjbgf commented Aug 18, 2022

Added an additional commit (76fd0ab) to fix issue with non-fuzz funcs.
The same fix was proposed upstream, so I will move this PR back to draft in the mean time. We can go ahead merging this here, and once that fix is merged upstream we can simply revert that specific commit.

@pjbgf pjbgf marked this pull request as draft August 18, 2022 09:36
Moving into Go Native, the adhoc changes and on-demand build is no
longer necessary.

Previously calls to r.EventRecorder.AnnotatedEventf resulted in panic.
The new dummy recorder resolves the problem without impacting
resource consumption.

A new make target `fuzz-native` was introduced, to loop through all
fuzz tests for the duration of time specified via the environment
variable `FUZZ_TIME`.

Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
@pjbgf pjbgf marked this pull request as ready for review August 22, 2022 15:40
@pjbgf pjbgf merged commit 7424704 into fluxcd:main Aug 24, 2022
@pjbgf pjbgf deleted the fix-fuzz branch August 24, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants