Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notation verification provider to API #930

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

stefanprodan
Copy link
Member

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the area/api API related issues and pull requests label Apr 2, 2024
@stefanprodan stefanprodan requested a review from souleb April 2, 2024 18:04
@souleb
Copy link
Member

souleb commented Apr 2, 2024

we should add a test for it in helmchart_template_test.go.

@stefanprodan
Copy link
Member Author

we should add a test for it in helmchart_template_test.go

We do have a test for the verify fields, duplicating the current test and changing the string value would not do anything as the kubebuilder validation doesn't run, helmchart_template_test.go uses a mock client.

Copy link
Member

@souleb souleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @stefanprodan

@stefanprodan stefanprodan merged commit 64073a8 into main Apr 3, 2024
7 checks passed
@stefanprodan stefanprodan deleted the add-notation-provider branch April 3, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants