Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the chart app version to status and events metadata #968

Merged
merged 3 commits into from
May 7, 2024

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented May 7, 2024

This PR adds the chart app version to the .status.history snapshot and sets the app-version annotation to all the issued events.

This PR makes possible to expose chart_app_version as a label on the gotk_resource_info metric, ref: fluxcd/flux2-monitoring-example#36

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added enhancement New feature or request area/helm Helm related issues and pull requests area/ux In pursuit of a delightful user experience labels May 7, 2024
@stefanprodan stefanprodan added this to the Helm GA milestone May 7, 2024
@stefanprodan stefanprodan requested a review from a team May 7, 2024 05:48
Copy link
Member

@relu relu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stefanprodan stefanprodan changed the title Add the chart app version to events metadata Add the chart app version to status and events metadata May 7, 2024
Copy link
Member

@souleb souleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit 921def6 into main May 7, 2024
6 checks passed
@stefanprodan stefanprodan deleted the app-version-meta-event branch May 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests area/ux In pursuit of a delightful user experience enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants