Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Commit

Permalink
Make OwnedByHelmRelease default to true
Browse files Browse the repository at this point in the history
To work around an edge case scenarios some users have reported where
the release manifest does not result in any resources (or they are
all skipped), and the `HelmRelease` is therefore falsely marked as
'not being owned by'.

This should all be refactored to an `ownerReference`, so that we can
make use of Kubernetes' garbage collection functionalities[1] and no
longer reinvent the wheel.

[1]: https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/#owners-and-dependents
  • Loading branch information
hiddeco committed Sep 30, 2019
1 parent 5cadd85 commit c84fbae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/release/release.go
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ func (r *Release) OwnedByHelmRelease(release *hapi_release.Release, hr helmfluxv
}
}

return false
return true
}

// annotateResources annotates each of the resources created (or updated)
Expand Down

0 comments on commit c84fbae

Please sign in to comment.