This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 265
Improve duration metrics #406
Labels
blocked needs validation
In need of validation before further action
enhancement
New feature or request
Comments
seaneagan
added a commit
to seaneagan/helm-operator
that referenced
this issue
May 5, 2020
seaneagan
added a commit
to seaneagan/helm-operator
that referenced
this issue
May 5, 2020
seaneagan
added a commit
to seaneagan/helm-operator
that referenced
this issue
May 5, 2020
seaneagan
added a commit
to seaneagan/helm-operator
that referenced
this issue
May 5, 2020
hiddeco
pushed a commit
to seaneagan/helm-operator
that referenced
this issue
May 11, 2020
hiddeco
pushed a commit
to seaneagan/helm-operator
that referenced
this issue
May 11, 2020
hiddeco
pushed a commit
to seaneagan/helm-operator
that referenced
this issue
May 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
blocked needs validation
In need of validation before further action
enhancement
New feature or request
Issues
release_phase_duration_seconds
should not reference "phase", and should instead reference "action" as per the "action" label it supports.release_duration_seconds
as a name implies an entire release process, i.e. multiple sync attempts when retries are necessary. However the data it exposes is only about a single sync attempt.release_name
self-documents that it refers to thereleaseName
and not themetadata.name
of theHelmRelease
, but thenamespace
label does not self-document that it refers to thetargetNamespace
and notmetadata.namespace
of theHelmRelease
.Proposal
Deprecate these metrics (still support for some time but remove from docs) and add and document a new metric called
release_action_duration_seconds
(corrected name) which also encompassesrelease_duration_seconds
functionality by adding support for async
value to theaction
label. Also this metric would replace thenamespace
label with atarget_namespace
label.The text was updated successfully, but these errors were encountered: