This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Build: include both major Helm version binaries in image #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The e2e tests expects a binary called |
hiddeco
force-pushed
the
helm-v3/helm-binaries
branch
3 times, most recently
from
2438eeb
to
fe81227
Compare
hiddeco
force-pushed
the
helm-v3/helm-binaries
branch
from
fe81227
to
0d6eee1
Compare
|
@hiddeco will the helm deps build still work after the renaming? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Helm
v2andv3binaries to the Docker image. It also adds the base for running the end-to-end tests targeting a specific Helm version, but does not yet take the targeted version into account during the installation procedure itself.