This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
chartsync: use target helm version for download #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having to shell out to the `helm2` binary while still maintaining the same functionality. It aligns with the approach used in `helm/v3`.
hiddeco
force-pushed
the
helm-v3/chart-download
branch
2 times, most recently
from
2fd25cc
to
75a9689
Compare
stefanprodan
approved these changes
Dec 13, 2019
This commit achieves three things: 1. The logic for resolving the full chart URL has been moved to the client version implementations, adding two new methods `Pull` and `PullWithRepoURL`. The latter implements the logic for retrieving the full chart URL that was earlier present in the `chartsync` package itself. This ensures the accurate repositories index is used when we look for chart repository credentials. 2. The newly introduced `Pull` method makes use of the `downloader.ChartDownloader` for that Helm version. This makes it easier to integrate e.g. the pull of OCI charts once this feature becomes available in Helm v3. It also provides some groundwork for working with named repositories which we may want to use later on when we have introduced the Custom Resource for manging Helm repositories, as it now understands the `repo/name` format. 3. The chartsync now maintains a chart cache per Helm version by appending the `helm.Version()` to the `base`.
hiddeco
force-pushed
the
helm-v3/chart-download
branch
from
75a9689
to
9bacf87
Compare
hiddeco
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.