This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
helm/v2: index repositories before fetching chart #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanprodan can you add a reference to the comment in the Helm code base that made this clear to you? This will probably help in the future when someone is looking for additional context around this (somewhat inefficient) piece of code. |
stefanprodan
force-pushed
the
fix-helmv2-dowloader
branch
4 times, most recently
from
2e277a2
to
b2521c1
Compare
|
@hiddeco I've added a link to the Helm source code. |
hiddeco
changed the title
hiddeco
force-pushed
the
fix-helmv2-dowloader
branch
from
b2521c1
to
f795f54
Compare
hiddeco
approved these changes
Jan 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #164
Helm v2
ResolveChartVersionneeds to go through each repo cache file to find a matching URL, so we need to download all indexes before attempting to download charts.Ref: https://github.com/helm/helm/blob/release-2.16/pkg/downloader/chart_downloader.go#L158