This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
release: ignore manifest in annotator if we fail to unmarshal #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansedich
commented
Jan 8, 2020
|
After talking with @hiddeco going to dive in and try understand where the "null" is actually coming from. |
stefansedich
force-pushed
the
null-kind-fix
branch
from
9c5527c
to
a00e404
Compare
stefansedich
commented
Jan 9, 2020
stefansedich
force-pushed
the
null-kind-fix
branch
2 times, most recently
from
611da84
to
33dd847
Compare
hiddeco
changed the title
stefansedich
force-pushed
the
null-kind-fix
branch
from
33dd847
to
a9c6c97
Compare
hiddeco
approved these changes
Jan 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#185 covered the case where the len(bytes)==0 however in my testing I witnessed that the reason I still get this error is because I am seeing manifests come through that are simply the string "null".