This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
helm: if present, use repository alias to pull a chart #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
helm/repository-auth
branch
from
22ceaac
to
31ef02e
Compare
hiddeco
force-pushed
the
helm/repository-auth
branch
from
31ef02e
to
f70f571
Compare
hiddeco
force-pushed
the
helm/repository-auth
branch
from
f70f571
to
5c4eb06
Compare
This is a workaround for some problems that exist in Helm while attempting to fetch a chart with an absolute URL, while it also makes things a bit more efficient. The problem is that the authentication credentials for an URL are looked up by Helm based on the URLs of the index file that is present for the repository. This itself is not a problem as long as the chart repository is configured to list absolute URLs in their index, some repositories however are configured to list relative URLs, which will make the credential lookup fail.
This is a follow up on #171 and makes the credential lookup built-in to Helm's `ChartDownloader` work, instead of providing (fallback) options.
hiddeco
force-pushed
the
helm/repository-auth
branch
from
5c4eb06
to
8c89efb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186