This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
release: allow MaxHistory to be overriden for a HelmRelease #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
reviewed
Jan 21, 2020
stefansedich
force-pushed
the
v3-history-max
branch
3 times, most recently
from
d99074a
to
bd7548c
Compare
|
@hiddeco added to CRD I assume this was manual as I had done? |
stefansedich
force-pushed
the
v3-history-max
branch
2 times, most recently
from
bf9490d
to
79b9cef
Compare
stefansedich
force-pushed
the
v3-history-max
branch
from
79b9cef
to
2d48456
Compare
hiddeco
reviewed
Jan 22, 2020
test/e2e/25_max_history.bats
Outdated
Comment on lines
33
to
34
| count=$(k get secret -n $DEMO_NAMESPACE --output name | grep 'sh.helm.release.v1.podinfo-helm-repository' | wc -l) | ||
| [ "$count" -le 10 ] |
There was a problem hiding this comment.
I think it is wiser to not use our human knowledge here about the configured storage mechanism but instead exec into the running container and use the helm3 binary there to get this information. This would make the end-to-end tests still succeed if for some reason the storage mechanism is configured differently.
I also think the stricter [ "$count" -eq 10 ] can be used, given we use poll_until_equals in the for loop and there should thus be no divergence due to e.g. the operator not being ready with processing.
hiddeco
reviewed
Jan 22, 2020
hiddeco
reviewed
Jan 22, 2020
stefansedich
force-pushed
the
v3-history-max
branch
from
2d48456
to
f53a441
Compare
stefansedich
commented
Jan 22, 2020
stefansedich
commented
Jan 22, 2020
hiddeco
approved these changes
Jan 22, 2020
hiddeco
changed the title
hiddeco
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the --history-max=10 was hard-coded and not user configurable, this adds
maxHistoryto the HelmRelease CRD to allow a user to override this if desired.@hiddeco hoping I got all the required bits this is my first CRD related PR let me know what I am missing.
Closes #224