This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
release: rely on Helm storage for rollbacks #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's run the e2e tests for a ten times, the rollback revision issue happens often so with this PR it should stop. |
hiddeco
force-pushed
the
bug/spurious-rollbacks-git
branch
3 times, most recently
from
7bd985a
to
c695af2
Compare
hiddeco
force-pushed
the
bug/spurious-rollbacks-git
branch
from
c695af2
to
72f8847
Compare
This commit removes our own state keeping around rollbacks except for the condition we set marking a rollback has happened, but instead relies on comparison of a dry-run with the latest failed release. If this results in a diff, a new upgrade will be attempted. The reason we move to this approach is that it is not possible to take all variables safely into account and determine if we should perform a new upgrade attempt based on our own bookkeeping, with a long list of edge-case bugs as a result. Relying on the real truth is always better than a reflection of it, which in the end may not be the actual truth at all.
hiddeco
force-pushed
the
bug/spurious-rollbacks-git
branch
from
72f8847
to
976cc05
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes our own state keeping around rollbacks except
for the condition we set marking a rollback has happened, but
instead relies on comparison of a dry-run with the latest failed
release. If this results in a diff, a new upgrade will be attempted.
The reason we move to this approach is that it is not possible to
take all variables safely into account and determine if we should
perform a new upgrade attempt based on our own bookkeeping, with
a long list of edge-case bugs as a result.
Relying on the real truth is always better than a reflection of it,
which in the end may not be the actual truth at all.
Fixes #236