This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
helm: do not include non-template files in chart data #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the non-template files include the `requirements.lock` file, which in case of a chart with dependencies differs every time a dry-run happens due to the generation timestamp it includes, resulting in spurious upgrades. Other files included there are non-trivial for the detection of changes as their effects are either captured in other parts of the chart metadata, or do not matter at all for the release itself, like the contents of a `README.md`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the non-template files include the
requirements.lockfile,which in case of a chart with dependencies differs every time
a dry-run happens due to the generation timestamp it includes,
resulting in spurious upgrades.
Other files included there are non-trivial for the detection of
changes as their effects are either captured in other parts of
the chart metadata, or do not matter at all for the release
itself, like the contents of a
README.md.Fixes #218