-
Notifications
You must be signed in to change notification settings - Fork 265
build: do not create kind clusters in parallel #290
Conversation
2425aaa
to
ad7f013
Compare
Looks like |
@stefansedich looks like changing this to 2 clusters has made the flakiness of the test persistent, while this is great to debug what goes wrong, it doesn't help to reduce the flakiness of the cluster bootstrapping. |
d6c5b79
to
ad7f013
Compare
For the (public) record: persistent failure happens due to Tiller not being properly cleaned up in the teardown, as Two options:
|
Have gone for option #2, pushed and 🤞 for a solid CI experience. |
kubectl delete clusterrolebinding tiller-cluster-rule | ||
kubectl --namespace kube-system delete sa tiller | ||
kubectl --namespace "$E2E_NAMESPACE" delete sa tiller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this isn't really needed as we nuke the namespace but it does not hurt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is not aware of how it is utilized and should simply undo what its install
companion creates, so this is perfect.
3997b46
to
9affa6b
Compare
kubectl delete clusterrolebinding tiller-cluster-rule | ||
kubectl --namespace kube-system delete sa tiller | ||
kubectl --namespace "$E2E_NAMESPACE" delete sa tiller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is not aware of how it is utilized and should simply undo what its install
companion creates, so this is perfect.
fi | ||
} | ||
|
||
function uninstall_tiller() { | ||
helm2 reset --force | ||
helm2 reset --tiller-namespace "$E2E_NAMESPACE" --force |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a note here about the --force
flag, and the fact that this only resets the Tiller instance and not the release storage.
9affa6b
to
da75f37
Compare
da75f37
to
263f1de
Compare
bea42f8
to
2e8685c
Compare
2e8685c
to
7a8196b
Compare
Noticing the test flakes and saw the discussion in kubernetes-sigs/kind#1288 changing to 2 parallel jobs to see if that has any effect on stability of the e2e suite in CI, @hiddeco any objection to trying this out?
I also factored the e2e tests out into a CircleCI command which IMO cleans things up a little but required an update to the 2.1 build (which should not break anything else).