Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

helm/v3: add release name to log context for internal Helm logs #291

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

stefansedich
Copy link
Contributor

@stefansedich stefansedich commented Feb 12, 2020

Add release to log context for the logger func that is used to log internal helm logs.

Closes #240

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think besides adding the releaseName, it would probably also good to include the opts.Namespace as the same release name can exist in multiple namespaces since v3.

@stefansedich
Copy link
Contributor Author

Think besides adding the releaseName, it would probably also good to include the opts.Namespace as the same release name can exist in multiple namespaces since v3.

Makes sense, have added this, just want to do a final test and will take the PR out of draft.

@hiddeco hiddeco added the helm v3 Issue or PR related to Helm v3 label Feb 12, 2020
@hiddeco hiddeco changed the title release: add release name to log context for helm internal logs helm/v3: add release name to log context for internal Helm logs Feb 12, 2020
@stefansedich stefansedich force-pushed the helm-logging-release branch 2 times, most recently from 6659c03 to df6858e Compare February 12, 2020 15:06
@stefansedich stefansedich marked this pull request as ready for review February 12, 2020 15:06
@stefansedich
Copy link
Contributor Author

@hiddeco looks good:

ts=2020-02-12T15:03:59.402591551Z caller=helm.go:69 component=helm version=v3 info="creating 8 resource(s)" targetNamespace=demo release=skip-crd

PR ready to review.

@hiddeco hiddeco added the enhancement New feature or request label Feb 12, 2020
@hiddeco hiddeco merged commit 30295d1 into fluxcd:master Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request helm v3 Issue or PR related to Helm v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm/v3: enrich logger with release metadata
2 participants