Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

pkg: Helm v3.0.3 with global runtime.Scheme patch #292

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Feb 12, 2020

Closes #167

}

@test "When a HelmRelease is nested in a chart, an upgrade does succeed" {
# Install chartmuseum
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefansedich this will probably help you to address the CRD test with a local dummy chart.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great think that will, will update that test and send a PR over.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiddeco hiddeco merged commit c65c5de into master Feb 12, 2020
@hiddeco hiddeco deleted the helm-local-scheme branch February 12, 2020 14:34
@hiddeco hiddeco added build About the build or test scaffolding helm v3 Issue or PR related to Helm v3 labels Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build About the build or test scaffolding helm v3 Issue or PR related to Helm v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to update chart containing child HelmRelease and nested values
3 participants