Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Move to mkdocs #332

Merged
merged 8 commits into from
Mar 19, 2020
Merged

Move to mkdocs #332

merged 8 commits into from
Mar 19, 2020

Conversation

dholbach
Copy link
Member

@dholbach dholbach commented Mar 16, 2020

Let's move to mkdocs. The mkdocs-material theme looks nicer, we don't have to use eval_rst tricks and links with anchors work (recommonmark is unmaintained for a while already).

A test build can be seen here: https://test-helm-op.readthedocs.io/

@dholbach dholbach requested a review from hiddeco March 16, 2020 09:27
@dholbach dholbach mentioned this pull request Mar 16, 2020
@dholbach
Copy link
Member Author

dholbach commented Mar 16, 2020

TODO:

@dholbach dholbach force-pushed the move-to-mkdocs branch 4 times, most recently from d5f1fc7 to 98477e6 Compare March 16, 2020 11:50
@dholbach
Copy link
Member Author

Looks like I'll need help with the remaining bits (GH action to check links, review content and see if we're happy).

@stefanprodan
Copy link
Member

@dholbach can we have the Flux logo displayed in the toolbar?

@dholbach
Copy link
Member Author

Can somebody help me figure out the GH Action? I feel we're getting closer.

@dholbach
Copy link
Member Author

AFAICS all this still needs is:

  1. fix the GH Action to check links (important so we can figure out issues)
  2. review to make sure nav, look&feel, etc is generally fine for now
  3. beautification

@hiddeco
Copy link
Member

hiddeco commented Mar 16, 2020

The mkdocs version from the error does not match the version specified in requirements.txt:

https://github.com/fluxcd/helm-operator/pull/332/files#diff-93bd81aa3a2f0c02728220a6b46fb58dR1

     load_entry_point('mkdocs==0.16.3', 'console_scripts', 'mkdocs')()

This is the version apt installs:

2020-03-16T15:33:33.1807819Z Get:5 http://azure.archive.ubuntu.com/ubuntu bionic/universe amd64 mkdocs all 0.16.3-2 [452 kB]

@stefanprodan
Copy link
Member

@hiddeco
Copy link
Member

hiddeco commented Mar 16, 2020

Clicking on the logo results in landing on the homepage (fluxcd.io). I think landing on the homepage of the Helm operator documentation would be more user friendly.

@dholbach dholbach marked this pull request as ready for review March 16, 2020 15:52
@dholbach
Copy link
Member Author

I think we're good for review now. The logo and site_url have been changed and the GH action is working now.

@dholbach dholbach self-assigned this Mar 17, 2020
@dholbach dholbach added the docs Issue or PR related to documentation label Mar 17, 2020
@dholbach
Copy link
Member Author

Current URLs of helm-operator are:

https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/_static/css/theme.css
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/_static/pygments.css
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/_static/custom.css
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/genindex.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/search.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/references/index.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/guides/index.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/tutorials/index.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/faq.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/troubleshooting.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/references/operator.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/references/helmrelease-custom-resource.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/guides/upgrading-to-ga.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/guides/upgrading-to-beta.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/tutorials/get-started.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/tutorials/get-started-kustomize.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/index.html
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/references/
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/guides/
https://docs.fluxcd.io/projects/helm-operator/en/1.0.0-rc9/tutorials/

Do we want redirects?

README.md Outdated Show resolved Hide resolved
@stefanprodan
Copy link
Member

@dholbach the Helm Operator features list has been flattened, can you make it look like in the readme?

@dholbach
Copy link
Member Author

The feature list is the same as in the README, looks like indentation

  • a
  • b
    • c
  • d

doesn't work.

@dholbach
Copy link
Member Author

OK, fixed it now.

@stefanprodan
Copy link
Member

I propose we merge this into docs/revamp and make any other adjustments there.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dholbach dholbach merged commit ba106c0 into docs/revamp Mar 19, 2020
@dholbach dholbach deleted the move-to-mkdocs branch March 19, 2020 09:17
@hiddeco hiddeco added the build About the build or test scaffolding label Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build About the build or test scaffolding docs Issue or PR related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants