This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Imply release failure upon chart fetch failure #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaneagan
force-pushed
the
imply_release_failure
branch
from
cca58fe
to
bd596a3
Compare
seaneagan
force-pushed
the
imply_release_failure
branch
from
bd596a3
to
5c85c34
Compare
|
Closing this given #413 (comment). However happy to reopen and/or reconsider if the elaboration makes sense. |
hiddeco
approved these changes
May 11, 2020
There was a problem hiding this comment.
#413 (comment), LGTM @seaneagan 🌷
Needs a tiny rebase and merge conflict resolve before it can be merged.
Some phases require multiple conditions to be updated, this allows for that association.
seaneagan
force-pushed
the
imply_release_failure
branch
from
5c85c34
to
44d45ce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #413.