This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Fix e2e tests on MacOS. #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
approved these changes
May 4, 2020
hiddeco
force-pushed
the
fix-e2e-tests-on-mac
branch
from
2298b70
to
51c60e3
Compare
|
Thank you @vladlosev 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes e2e tests on MacOS. Some of the tests use the
sedcommand with the-ioption to modify files in place. On Linux, that option has an optional parameter specifying the name of the back-up file to create. On the standardsedinstallation in MacOS, the parameter for-iis required (it may be empty though, in which case no back-up file is created), so the tests fail with this message:This change modifies sed invocation to work on MacOS. This should help with the development of Helm Operator on Mac.