This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 265
helm/v3: garbage collect anonymous index files #422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baa18ad
to
fe9e671
Compare
squaremo
reviewed
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments 💬!
307f98b
to
05f2b82
Compare
squaremo
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍇
The Helm 3 dependency update generates anonymous index files on every run without garbage collecting them, resulting in spurious disk usage. Configuring a temporary cache directory and garbage collecting it after the dependency update is not possible as the download manager seems to ignore the configured repository cache path and always create the index file in the XDG cache directory. Instead we detect the any anonymous index filex by their "=" suffix and delete if they are older than 2m.
05f2b82
to
a93c2d4
Compare
I updated to helm-operator 1.1.0 but this problem is still there as
|
Clearly states you are still running |
me 👎. Thanks @hiddeco |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Helm 3 dependency update generates anonymous index files on every
run without garbage collecting them, resulting in spurious disk usage.
Configuring a temporary cache directory and garbage collecting it after
the dependency update is not possible as the download manager seems to
ignore the configured repository cache path and always create the index
file in the XDG cache directory.
Instead we detect the any anonymous index filex by their "=" suffix and
delete if they are older than 2m.