Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Set release_condition_info labels properly #431

Merged
merged 1 commit into from May 27, 2020
Merged

Set release_condition_info labels properly #431

merged 1 commit into from May 27, 2020

Conversation

sa-spag
Copy link
Contributor

@sa-spag sa-spag commented May 27, 2020

Hey there 馃憢

Both target_namespace and release_name were wrongly set using the HelmRelease metadata. It may be worth releasing this as a patch.

@hiddeco hiddeco added the bug Something isn't working label May 27, 2020
hiddeco
hiddeco approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will likely make it to a patch release but I can't give you an exact time or date.

@hiddeco hiddeco merged commit db2188f into fluxcd:master May 27, 2020
@sa-spag sa-spag deleted the fix-prom-labels branch May 27, 2020 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sa-spag @hiddeco