Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Use sigs.k8s.io/yaml everywhere #455

Merged
merged 1 commit into from Jun 15, 2020
Merged

Use sigs.k8s.io/yaml everywhere #455

merged 1 commit into from Jun 15, 2020

Conversation

hezhizhen
Copy link
Contributor

No description provided.

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, and likely the result of some past merge-conflict. Looking at the Helm source however, sigs.k8s.io/yaml is used. Given this, I think the change should be made in values.go and not in the test.

@hezhizhen
Copy link
Contributor Author

Good catch, and likely the result of some past merge-conflict. Looking at the Helm source however, sigs.k8s.io/yaml is used. Given this, I think the change should be made in values.go and not in the test.

So I should replace github.com/ghodss/yaml with sigs.k8s.io/yaml not vice versa?

@hiddeco
Copy link
Member

hiddeco commented Jun 15, 2020

Correct.

@hezhizhen
Copy link
Contributor Author

Done.

Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hezhizhen 🌷

@hiddeco hiddeco changed the title Use the same YAML lib Use sigs.k8s.io/yaml everywhere Jun 15, 2020
@hiddeco hiddeco merged commit 503d64f into fluxcd:master Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants