Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Adding support for optional rollback/uninstall when helm test fails #472

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Adding support for optional rollback/uninstall when helm test fails #472

merged 2 commits into from
Jul 1, 2020

Conversation

chrisjholly
Copy link
Contributor

Fixes #454

Linked PR #463

@chrisjholly chrisjholly mentioned this pull request Jun 25, 2020
Closed
@chrisjholly
Copy link
Contributor Author

@hiddeco PR with clean changes from #463 with @seaneagan comments addressed.

@hiddeco
Copy link
Member

hiddeco commented Jun 26, 2020

@ChrisHolly it appears that some of the Helm test tests are flakey, especially the when test.enable and rollback.enable are set, releases with timed out tests are rolled back one gave problems in #471.

seaneagan
seaneagan suggested changes Jun 26, 2020
View reviewed changes
docs/helmrelease-guide/tests.md Outdated Show resolved Hide resolved
test/e2e/40_tests.bats Outdated Show resolved Hide resolved
test/e2e/40_tests.bats Outdated Show resolved Hide resolved
pkg/status/conditions.go Outdated Show resolved Hide resolved
test/e2e/fixtures/releases/test/fail-no-rollback.yaml Show resolved Hide resolved
@seaneagan
Copy link
Contributor

@ChrisHolly it appears that some of the Helm test tests are flakey, especially the when test.enable and rollback.enable are set, releases with timed out tests are rolled back one gave problems in #471.

It looks like the grpc helm test pod for the podinfo chart failed, but there are no logs captured for that test pod so not sure why. If we see it again I can look into addressing.

chrisjholly pushed a commit to chrisjholly/helm-operator that referenced this pull request Jun 27, 2020
@chrisholly-skyuk
Adding changes following review on fluxcd#472
830bf05 
Signed-off-by: Chris Holly <chris.holly@sky.uk>
chrisjholly pushed a commit to chrisjholly/helm-operator that referenced this pull request Jun 27, 2020
@chrisholly-skyuk
Adding changes following review on fluxcd#472
aba5701 
Signed-off-by: Chris Holly <chris.holly@sky.uk>
chrisjholly pushed a commit to chrisjholly/helm-operator that referenced this pull request Jun 27, 2020
@chrisholly-skyuk
Adding changes following review on fluxcd#472
8feae90 
Signed-off-by: Chris Holly <chris.holly@sky.uk>
@chrisjholly chrisjholly marked this pull request as draft June 27, 2020 20:54
chrisjholly pushed a commit to chrisjholly/helm-operator that referenced this pull request Jun 27, 2020
@chrisholly-skyuk
[Reverting] Adding changes following review on fluxcd#472
840c8ea 
Signed-off-by: Chris Holly <chris.holly@sky.uk>
@chrisjholly chrisjholly force-pushed the helm_operator_454 branch 5 times, most recently from 4eac235 to 3331662 Compare June 29, 2020 19:44
@chrisjholly chrisjholly marked this pull request as ready for review June 29, 2020 20:30
seaneagan
seaneagan suggested changes Jun 29, 2020
View reviewed changes
pkg/release/release.go Show resolved Hide resolved
test/e2e/40_tests.bats Show resolved Hide resolved
pkg/release/release.go Outdated Show resolved Hide resolved
@chrisjholly chrisjholly force-pushed the helm_operator_454 branch 2 times, most recently from b91db7e to 6c475e3 Compare June 30, 2020 13:43
seaneagan
seaneagan reviewed Jun 30, 2020
View reviewed changes
test/e2e/40_tests.bats Outdated Show resolved Hide resolved
seaneagan
seaneagan reviewed Jun 30, 2020
View reviewed changes
test/e2e/40_tests.bats Outdated Show resolved Hide resolved
seaneagan
seaneagan approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@seaneagan seaneagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisjholly lgtm, thanks for picking this up!

test/e2e/40_tests.bats Show resolved Hide resolved
test/e2e/40_tests.bats Show resolved Hide resolved
@chrisjholly @hiddeco
Update docs/helmrelease-guide/tests.md
507d78a 
Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com>
hiddeco
hiddeco approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for being patient with the requested changes @chrisjholly, and thanks a lot for the rigorous reviews @seaneagan. 🌷

@hiddeco hiddeco merged commit 20f0cf9 into fluxcd:master Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seaneagan seaneagan seaneagan approved these changes

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to ignore (or not) helm test failures
4 participants
@chrisjholly @hiddeco @seaneagan @chrisholly-skyuk