This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add flag for disabling OpenAPI Validation for Helm 3 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waseem-h
changed the title
|
CC @hiddeco @stefanprodan can any of you guys review this please? |
hiddeco
force-pushed
the
add-oapi-disable-flag
branch
from
39f7c6b
to
a2f74f2
Compare
hiddeco
approved these changes
Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement
Helm 3 allows us to disable OpenAPI Validation when building resources via kubernetes client and we've been using that so that we can have a helm chart that works for all kubernetes versions. An example is https://github.com/curityio/idsvr-helm/blob/master/idsvr/templates/cluster-conf.yaml#L46
It works fine with helm 2 HelmRelease but not with helm 3 without specifying the
--disable-openapi-validationflag on the helm command. Adding it to the HelmRelease allows us to pass it to the helm 3 API so that it doesn't validate our templates