Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Resolve panic on delete and improve tests #495

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Resolve panic on delete and improve tests #495

merged 1 commit into from
Jul 22, 2020

Conversation

saada
Copy link
Contributor

@saada saada commented Jul 21, 2020 •
edited by hiddeco
Loading

  • Fix Panic on delete #493 panic on deletes and improve delete error handling
  • tests
    • add test that was failing without the changes and passed after adding changes
    • Wait for tiller to be READY
    • Add new poll function poll_no_restarts and use it to check at the end of every test if a restart occurred in the operator
    • Show logs of previous shut down container to help in debugging failures

luxas
luxas reviewed Jul 22, 2020
View reviewed changes
pkg/status/metrics.go Outdated Show resolved Hide resolved
hiddeco
hiddeco reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion... we should add the poll_no_restarts and kubectl logs -p to teardowns in other relevant tests.

This would be a welcome addition.

@saada saada force-pushed the bugfix/panic-on-delete branch 5 times, most recently from fa84635 to 3b80a2c Compare July 22, 2020 12:22
resolves fluxcd#493 - panic on delete
1bee270 
add improved teardowns and poll_no_restarts at end of every test

handle nil conditionstatus
@saada saada changed the title resolves #493 - panic on delete resolves #493 - panic on delete and improve tests Jul 22, 2020
@hiddeco hiddeco changed the title resolves #493 - panic on delete and improve tests Resolve panic on delete and improve tests Jul 22, 2020
@hiddeco hiddeco merged commit 8a51a7b into fluxcd:master Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas left review comments

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic on delete
3 participants
@saada @luxas @hiddeco