This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add more Helm chart dashboard options #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange error, could someone restart the CI ? |
uberspot
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Sorry for pinging @hiddeco but would it be possible to get this merged?
This would allow changing the name of the dashboard configmap per namespace and would make loading these dashboards automatically doable with something like grafana sidecars https://github.com/helm/charts/tree/master/stable/grafana#configuration when we have multiple helm-operators deployed in a cluster.
Right now if you load all these configmaps with the sidecar they overwrite each other because the name is the same for all of them.
Specifically from grafana sidecar:
t=2020-10-02T11:02:32+0000 lvl=eror msg="the same 'uid' is used more than once" logger=provisioning.dashboard type=file name=sidecarProvider uid=...redacted... provider=sidecarProvider
hiddeco
approved these changes
Oct 2, 2020
|
Nice! :) thank you! Checks passed too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flux-dashboard.jsonintoflux.jsonto avoid naming like flux-dashboards-flux-dashboardnameprefixinto dashboards values to allow better naming possibilitiesnamespaceinto dashboards values to allow users to put dashbards in a different namespaceSee fluxcd/flux#3183