This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add terminationGracePeriodSeconds value to Helm Operator Chart
#564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that the default timeout when upgrading a chart is 300s, why not also set the default terminationGracePeriod to 300s ? |
Good point. Updated! |
hiddeco
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
LGTM 👍
Can you please rebase your PR, smash the commits, and sign-off your commit? https://github.com/fluxcd/helm-operator/pull/564/checks tells you how to do the latter.
added 3 commits
February 9, 2021 10:06
This is necessary when timeout may be set to a higher value to help ensure that Helm Operator isnt killed before its done waiting for an operation to finish.
hiddeco
force-pushed
the
terminationGracePeriod
branch
from
249c9bc
to
73af3cd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary when timeout may be set to a higher value to help ensure that Helm Operator isnt killed before its done waiting for an operation to finish. Also correct spelling.
As outlined here: https://github.com/fluxcd/helm-operator/blob/master/docs/helmrelease-guide/release-configuration.md#configuring-the-timeout