Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Remove the query string from the CleanURL #571

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

smarthall
Copy link
Contributor

We are using Azure Blob storage as a private Helm repository. As described here. This breaks in helm-operator because the SAS token makes the cache directory too long and it fails with the following message:

synchronization of release 'demo' in namespace 'default' failed: failed to prepare chart for release: chart unavailable: mkdir /tmp/v3/[LONG FILE NAME]: file name too long

This PR strips the query string from the repo url that is used for caching so that:

  1. If the authentication token changes the same cache can still be used.
  2. The directory name is shorter

@smarthall smarthall force-pushed the ignore-query-string-in-cleanurl branch from 645ecd5 to 800414a Compare December 1, 2020 05:21
Copy link
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much! This should be fine to be included in the next patch release 🥇

Before I merge, can you please rebase your PR?

Signed-off-by: Daniel Hall <dhall@starrez.com>
@smarthall smarthall force-pushed the ignore-query-string-in-cleanurl branch from 800414a to 0cfea87 Compare December 10, 2020 00:34
@smarthall
Copy link
Contributor Author

You are welcome, thanks for merging it.

I've rebased onto the latest master.

@hiddeco hiddeco merged commit 8a3f39f into fluxcd:master Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants