This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Build: support non $GOPATH/src location for codegen
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanprodan
approved these changes
Aug 12, 2019
hiddeco
force-pushed
the
build/check-generated
branch
5 times, most recently
from
4ebf968
to
b2aaaa0
Compare
This commit fixes two things: - it ensures the code generation works no matter the location of the project directory - as a side effect; fixes the `hack/verify-codegen.sh` ran during CI The previous script (or more specific: the `code-generator` library) made the assumption during execution that the project was placed inside `$GOPATH/src` and made the modifications there. The idea of Go Modules is however that a project and/or package can be placed anywhere, and this is also what the CI did, resulting in a comparison of two identical `cp -r` copied directories. Giving a false green light on every CI run. To work around this limitation in `code-generator`: create a temporary directory, use this as an output base and copy everything back once generated.
hiddeco
force-pushed
the
build/check-generated
branch
from
b2aaaa0
to
51f6324
Compare
hiddeco
changed the title
$GOPATH/src location for codegen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes two things:
project directory
hack/verify-codegen.shran during CIThe previous script (or more specific: the
code-generatorlibrary)made the assumption during execution that the project was placed
inside
$GOPATH/srcand made the modifications there.The idea of Go Modules is however that a project and/or package can
be placed anywhere, and this is also what the CI did, resulting in a
comparison of two identical
cp -rcopied directories. Giving afalse green light on every CI run.
To work around this limitation in
code-generator: create atemporary directory, use this as an output base, and copy
everything back once generated.