This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Update RBAC version #618
Merged
Update RBAC version #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Laine <philip.laine@gmail.com> Signed-off-by: Kingdon Barrett <yebyen@gmail.com>
The cluster rbac and rbac roles in the helm chart templates can still reference the old v1beta1 rbac.authorization.k8s.io API, which must be removed in preparation for K8s 1.22. The CRD changes already meant that Kubernetes 1.16+ was required in the (next) newest version of Helm Operator. This change requires K8s 1.8+ so, while we can mention it separately in the release notes, it does not add any additional functional requirement for the users, as they must already upgrade to this version or greater. Signed-off-by: Kingdon Barrett <yebyen@gmail.com>
kingdonb
force-pushed
the
update/rbac-version
branch
from
7d927eb
to
4a3a81c
Compare
|
This PR is already in 1.4.0-rc1 👍 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Piggybacking off #599, this PR removes the last vestiges of
rbac.authorization.k8s.io/v1beta1in favor ofrbac.authorization.k8s.io/v1that has been available since Kubernetes 1.8. This is also required for K8s 1.22.x next release.I gave this some testing with a chartmuseum and the test suite that #599 provided, and I was able to install it on Kubernetes 1.22.0-alpha.3 which I've been working on to be sure we catch all the deprecations.
There is a PR at kingdonb#1 where I am noodling around with the
crd-testchart, to prove to my satisfaction that Helm Operator can install charts based on the new CRD version (which I will open against my own fork, for now; I'm not sure how to incorporate them for merging just yet.)