Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Towards Toolkit compatibility #28

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Towards Toolkit compatibility #28

merged 2 commits into from
Oct 26, 2020

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Oct 22, 2020 •
edited

Changes:

  • Generate CRDs using the stable apiextensions
  • Update go to 1.5
  • Use alpine as base image for multi-arch builds
  • Set readonly FS and mount /tmp
  • Expose Prometheus metrics endpoint

Things that should be addressed in other PRs:

  • structured logging
  • events
  • watch-all-namespaces toggle
  • liveness/readiness probes with controller-runtime
  • multi-arch build and release workflow
  • e2e tests with Kubernetes Kind

@stefanprodan
Generate CRDs using the stable apiextensions
e7ec904 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Enable multi-arch build
38b4eb2 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@squaremo
Copy link
Member

squaremo commented Oct 26, 2020 •
edited

For me to keep track of at least filing issues:

squaremo
squaremo approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@squaremo squaremo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks reasonable, thanks Stefan

@squaremo squaremo merged commit 35a3035 into main Oct 26, 2020
@squaremo squaremo deleted the toolkit-compatibility branch October 26, 2020 11:49
@squaremo squaremo mentioned this pull request Nov 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squaremo squaremo squaremo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanprodan @squaremo