Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tests for update accept function #636

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

zhaque44
Copy link
Contributor

@zhaque44 zhaque44 commented Feb 2, 2024

Tests for Accept - Scalar Node:

Description: Tests the accept function when provided with a scalar node and valid setter schema.
The function should not return an error (assert.NoError).
The expected error value should be false (assert.Equal).

Tests for Accept - Scalar Node - Error:

Description: Tests the accept function when provided with a scalar node, with invalid setter schema.
The function should not return an error (assert.NoError).
The expected error value should be true (assert.Equal).

Signed-off-by: zhaque44 <haque.zubair@gmail.com>
@zhaque44
Copy link
Contributor Author

zhaque44 commented Feb 2, 2024

@stefanprodan I opened a new PR, disregard the last one

@stefanprodan stefanprodan added the area/testing Testing related issues and PRs label Feb 2, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @zhaque44 🏅

@stefanprodan stefanprodan merged commit 65b8b1d into fluxcd:main Feb 2, 2024
8 checks passed
@zhaque44 zhaque44 deleted the accept-function-filter-tests branch February 13, 2024 17:32
@darkowlzz darkowlzz changed the title adding tests for accept function adding tests for update accept function May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants