Introduce ResultV2 for update results #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
stefanprodan
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
LGTM
Great job on making this backwards compatible! Thanks @darkowlzz 🎖️
ResultV2 update result contains Result (original), which provides information in terms of files, objects and images, and also includes file changes which provides information in terms of files, objects and changes. The changes contain the old value, new value and the setter that was involved in the update. ResultV2 can be used to obtain detailed information about updates in terms of the previous value and the new value, which could be beneficial in commit messages to summarize the granular changes. Signed-off-by: Sunny <github@darkowlzz.space>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResultV2update result containsResult(original), which provides information in terms of files, objects and images, and also includes file changes which provides information in terms of files, objects and changes. The changes contain the old value, new value and the setter that was involved in the update.ResultV2can be used to obtain detailed information about updates in terms of the previous value and the new value, which could be beneficial in commit messages to summarize the granular changes.ResultV2is introduced in a backwards compatible way. The existing behavior is not changed. It will only be used by the refactored controller in the future. Introducing it in the main branch to keep the refactored controller changes small.Related to #437