Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for getExtFromSchema #658

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

zhaque44
Copy link
Contributor

@zhaque44 zhaque44 commented Mar 28, 2024

Tests Scenario: Extension Present

This scenario tests that the schema contains a valid extension with a setter, then verifies that the function correctly extracts the extension from the schema and returns it without an error.

Tests Scenario: Extension Not Present

This scenario tests the function when the schema does not contain any extension & verifies that the function returns nil without an error when no extension is found in the schema.

Signed-off-by: zhaque44 <haque.zubair@gmail.com>
@zhaque44
Copy link
Contributor Author

zhaque44 commented Apr 2, 2024

@stefanprodan good morning, hope you are well can you please take a look?

@stefanprodan stefanprodan added the area/testing Testing related issues and PRs label Apr 2, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @zhaque44

@stefanprodan stefanprodan changed the title adding tests for getExtFromSchema Add tests for getExtFromSchema Apr 2, 2024
@stefanprodan stefanprodan merged commit 9728b40 into fluxcd:main Apr 2, 2024
8 checks passed
@zhaque44 zhaque44 deleted the get-ext-frm-schema-tests branch April 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants